mbrobbel commented on code in PR #14989: URL: https://github.com/apache/datafusion/pull/14989#discussion_r1978097980
########## datafusion/macros/src/macros.rs: ########## @@ -0,0 +1,10 @@ +#[macro_export] Review Comment: Unfortunately I don't think this works because: ``` error: cannot export macro_rules! macros from a `proc-macro` crate type currently ``` You could move the proc macros to a different crate and then re-export them in this crate, together with this macro maybe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
