Blizzara commented on code in PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#discussion_r1984591549
##########
datafusion/expr/src/udf.rs:
##########
@@ -225,11 +225,13 @@ impl ScalarUDF {
self.inner.is_nullable(args, schema)
}
+ #[deprecated(since = "46.0.0", note = "Use `invoke_with_args` instead")]
pub fn invoke_batch(
&self,
args: &[ColumnarValue],
number_rows: usize,
) -> Result<ColumnarValue> {
+ #[allow(deprecated)]
self.inner.invoke_batch(args, number_rows)
Review Comment:
Not really, since for invoke_with_args we'd need the return type which isn't
provided here. Also I don't see that as very important change anyways, this is
also `invoke_batch` and deprecated so passing directly through makes sense, and
both these `invoke_batch`s can be removed at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
