alamb commented on code in PR #15049: URL: https://github.com/apache/datafusion/pull/15049#discussion_r1985773876
########## datafusion/functions/benches/character_length.rs: ########## @@ -26,6 +28,8 @@ fn criterion_benchmark(c: &mut Criterion) { // All benches are single batch run with 8192 rows let character_length = datafusion_functions::unicode::character_length(); + let return_type = DataType::Utf8; Review Comment: I agree -- this change is fine. Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org