Blizzara commented on code in PR #15049:
URL: https://github.com/apache/datafusion/pull/15049#discussion_r1985164453
##########
datafusion/functions/benches/character_length.rs:
##########
@@ -26,6 +28,8 @@ fn criterion_benchmark(c: &mut Criterion) {
// All benches are single batch run with 8192 rows
let character_length = datafusion_functions::unicode::character_length();
+ let return_type = DataType::Utf8;
Review Comment:
I tried to look up what the correct return type should be, but there is
nothing validating that I got it correct nor that it won't get broken in the
future, e.g. if some of these functions start returning stringview instead. But
given these are benches, I guess that's fine? If the type is used and wrong,
presumably it'll complain somewhere, if it's not used and it's wrong it's not
the end of the world.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
