Blizzara commented on code in PR #15211:
URL: https://github.com/apache/datafusion/pull/15211#discussion_r1993980557
##########
datafusion/substrait/tests/cases/logical_plans.rs:
##########
@@ -45,6 +45,10 @@ mod tests {
"Projection: NOT DATA.D AS EXPR$0\
\n TableScan: DATA"
);
+
+ // Trigger execution to ensure plan validity
+ DataFrame::new(ctx.state(), plan).show().await?;
Review Comment:
I just added these for all of the cases, since some of my iterations passed
logical plan creation but failed at physical planning stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
