kazuyukitanimura commented on code in PR #1573:
URL: https://github.com/apache/datafusion-comet/pull/1573#discussion_r2014776467
##########
.github/workflows/spark_sql_test.yml:
##########
@@ -45,7 +45,7 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11]
- spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.5'}]
+ spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.4'}, {short: '3.5', full: '3.5.5'}]
Review Comment:
Since we advanced the minimum version to 3.5.5, I am not sure if we should
add back 3.5.4 tests.
SQL tests can be done here, but tests in Comet are not done with 3.5.4
anymore.
If we decide to support 3.5.4, I would vote for doing it by adding a maven
profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
