kazuyukitanimura commented on code in PR #1573:
URL: https://github.com/apache/datafusion-comet/pull/1573#discussion_r2014966200
##########
.github/workflows/spark_sql_test.yml:
##########
@@ -45,7 +45,7 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11]
- spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.5'}]
+ spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.4'}, {short: '3.5', full: '3.5.5'}]
Review Comment:
I would say we should create a separate Shims for Spark 3.5.4 where it is
necessary. I know it is right now we only do profile at 3.4, 3.5, 4.0 level.
but I observed a couple of API changes between patch version changes.
Comet Release for 3.5 does not mean that it works with all 3.5.x, currently.
Now the minimum version will be 3.5.5 in the next release. Either we drop the
3.5.4 support, or create a new profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
