YanivKunda commented on code in PR #1573:
URL: https://github.com/apache/datafusion-comet/pull/1573#discussion_r2015042394
##########
.github/workflows/spark_sql_test.yml:
##########
@@ -45,7 +45,7 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11]
- spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.5'}]
+ spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.4'}, {short: '3.5', full: '3.5.5'}]
Review Comment:
I went for the reflection approach after [my post-merge
discussion](https://github.com/apache/datafusion-comet/pull/1565#discussion_r2011249870)
with @wForget in #1565 -
since creating different shims for 3.5.4 also means a different release for
3.5.4, which might cause confusion for users.
Since I did the upgrade to 3.5.5 separately, dropping support for 3.5.4
simply means discarding this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
