YanivKunda commented on code in PR #1573:
URL: https://github.com/apache/datafusion-comet/pull/1573#discussion_r2014801685
##########
.github/workflows/spark_sql_test.yml:
##########
@@ -45,7 +45,7 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11]
- spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.5'}]
+ spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.4'}, {short: '3.5', full: '3.5.5'}]
Review Comment:
Adding a maven profile using spark 3.5.4 will break compilation for the 3.5
shim -
So to support both 3.5.4 and 3.5.5 in compilation we will need either
separate shims for each patch version,
or the 3.5 shim to support all versions through reflection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
