adriangb commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2793196830
> We will get this over the finish line in a few days. So you're going to make a PR to replace this one? Please do consider my example below. There's a lot more complexity than the simple API that @alamb proposed. I really think that: > Ultimately the issue in my mind is that how the recursion proceeds is in great part determined by each ExecutionPlan and that makes it hard to generalize into a set of standard APIs. We can try to come up with a set of APIs to describe all behaviors but: 1. It's going to be a complex API that relies on multiple methods being kept in sync / indexes mapping correctly. 2. I wouldn't be confident that it captures all behavior, e.g. in writing the original version I kept realizing that I'd missed edge cases with projections, joins, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
