alamb commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2794719805
> I tried to summarize our proposal with @ozankabak > https://synnada.notion.site/FilterPushdown-API-Proposal-1d1f46d2dab1802e80a7e1bccec2604f?pvs=73 Thank you @berkaysynnada -- I think this design sounds very reasonable to me and I would be happy to see it in DataFusion. However I don't think it fundamentally changes the filter pushdown that is possible so it is not clear to me that implementing a different API should hold up this PR (which is ready to go with comments and tests). Unless there some fundamental technical objections that I have missed, what I suggest is: 1. We merge this PR as is to unblock work on https://github.com/apache/datafusion/issues/15037 2. In parallel you work on the [API in the proposal](https://synnada.notion.site/FilterPushdown-API-Proposal-1d1f46d2dab1802e80a7e1bccec2604f?pvs=73) and when it is ready we can review it / merge it quickly If we are going to change the implementation anyways, I don't think doing so as a follow on PR is any more work than doing it in this PR and I expect the downstream impacts to be be minimal. The only potential concern I can see with this plan is API churn -- specifically changing a public API (especially as DF 47 nears release). I think in this case we could add a comment like the following as a hint to any downstream users that we plan to update the API shortly ```rust /// NOTE this API is subject to change in the near future ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
