alamb commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2794723836
BTW I don't seem to be able to leave comments on https://synnada.notion.site/FilterPushdown-API-Proposal-1d1f46d2dab1802e80a7e1bccec2604f so I will leave some here ```rust /// Result of try_pushdown_filters(), storing the necessary information about a filter pushdown trial struct FilterPushdownResult { // Filter predicates which can be pushed down through the operator. // NOTE that these are not placed into any operator. // **** NEW: NOTE these filters may be different than passed down if the operator changes schema (like projection) // ***** and may be different for different children (like for join) child_filters: Vec<FilterDescription>, // Filters which cannot be pushed down through the operator. // NOTE that caller of try_pushdown_filters() should handle these remanining predicates, // possibly introducing a FilterExec on top of this operator. remaining_filters: FilterDescription // Possibly updated new operator operator: Arc<dyn ExecutionPlan> } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
