berkaysynnada commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2796865438
> One more question: it seems like in all cases we end up eagerly cloning every node: `Join::try_new`. If I understand correctly this may even happen twice per node as we do the passes. > > Is this acceptable performance wise? I get that most things are Arc'ed but that's still a lot of copying. > > In my implementation I took a lot of care to make sure that if there were no filters being pushed, etc there was zero copying / node replacement, but maybe I overestimated the impact. You don't need to worry about that. I'm sure we can figure out a way of avoiding redundant clones -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
