berkaysynnada commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2796862617
> Could you help clarify when the FilterExec nodes get inserted? Maybe some examples with DataSourceExecs that do not accept any filters would help. You can look at the notion doc when the current node is AggregateExec. remaining_filters is the indicator of FilterExec requirement I've also thought on Dynamic filter case. Actually they are more flexible than normal filters. Normal filters are pulled off from the operator's itself, and pushed down as far as possible, and when it's not possible, a FilterExec is put accordingly. For the dynamic filters, as they are derived from normal filters, the actual filter's itself is not pulled off. So, like normal filters, dynamic filters also are pushed down along the plan, and when it's not possible to do further, again a normal FilterExec can be inserted for the Dynamic filters as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
