adriangb commented on PR #15566: URL: https://github.com/apache/datafusion/pull/15566#issuecomment-2801746776
> I've made an attempt [pydantic@2dfa8b8](https://github.com/pydantic/datafusion/commit/2dfa8b803f2103c6ff81cfa483dbb70150feeb67) > > I hope things becomes more clear now. I just tried to show the design idea, and I'm sure the final state will be much better after some polish Thank you @berkaysynnada! I merged your commit and tried to clean up the merge a bit. There are some failing tests, one at least seems like real bug with the `swap_remove` in https://github.com/pydantic/datafusion/blob/cda6e8d6b74e860e9978abf988c00d5a00d1ac07/datafusion/physical-optimizer/src/filter_pushdown.rs#L424. I have to run for a bit but if you can take a look that'd be great 🙏🏻 I think other than that the main thing we need is adding / better docs for the new APIs (in particular on `ExecutionPlan`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
