andygrove commented on code in PR #1655:
URL: https://github.com/apache/datafusion-comet/pull/1655#discussion_r2049397190
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2849,33 +2825,23 @@ object QueryPlanSerde extends Logging with
CometExprShim {
}
/**
- * Whether the given Spark partitioning is supported by Comet.
+ * Whether the given Spark partitioning is supported by Comet native shuffle.
*/
- def supportPartitioning(
- inputs: Seq[Attribute],
- partitioning: Partitioning): (Boolean, String) = {
- def supportedDataType(dt: DataType): Boolean = dt match {
- case _: ByteType | _: ShortType | _: IntegerType | _: LongType | _:
FloatType |
- _: DoubleType | _: StringType | _: BinaryType | _: TimestampType |
_: DecimalType |
- _: DateType | _: BooleanType =>
- true
- case _ =>
- // Native shuffle doesn't support struct/array yet
Review Comment:
yes, it does! This method is removed and we now have a single
`supportedShuffleDataType` method that is used for both native and columnar
shuffle type checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
