andygrove commented on code in PR #1655:
URL: https://github.com/apache/datafusion-comet/pull/1655#discussion_r2049396215
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2889,6 +2855,31 @@ object QueryPlanSerde extends Logging with CometExprShim
{
}
}
+ def supportedShuffleDataType(dt: DataType): Boolean = dt match {
+ case _: ByteType | _: ShortType | _: IntegerType | _: LongType | _:
FloatType |
+ _: DoubleType | _: StringType | _: BinaryType | _: TimestampType | _:
TimestampNTZType |
Review Comment:
This code was moved and is now new. I added `TimestampNTZType`.
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2889,6 +2855,31 @@ object QueryPlanSerde extends Logging with CometExprShim
{
}
}
+ def supportedShuffleDataType(dt: DataType): Boolean = dt match {
+ case _: ByteType | _: ShortType | _: IntegerType | _: LongType | _:
FloatType |
+ _: DoubleType | _: StringType | _: BinaryType | _: TimestampType | _:
TimestampNTZType |
Review Comment:
This code was moved and is not new. I added `TimestampNTZType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
