andygrove commented on code in PR #1667:
URL: https://github.com/apache/datafusion-comet/pull/1667#discussion_r2067187303
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -1253,9 +1254,8 @@ object CometSparkSessionExtensions extends Logging {
org.apache.spark.SPARK_VERSION >= "4.0"
}
- def usingDataFusionParquetExec(conf: SQLConf): Boolean =
- Seq(CometConf.SCAN_NATIVE_ICEBERG_COMPAT,
CometConf.SCAN_NATIVE_DATAFUSION).contains(
- CometConf.COMET_NATIVE_SCAN_IMPL.get(conf))
+ def usingDataFusionParquetExec(scanImpl: String): Boolean =
Review Comment:
This refactor has made the call sites more complex/verbose. Before, we had:
```scala
usingDataFusionParquetExec(conf)
```
and now we have
```scala
usingDataFusionParquetExec(CometConf.COMET_NATIVE_SCAN_IMPL.get(conf))
```
I don't see any calls where we pass in a string that didn't come from the
conf. @hsiang-c is this refactor really needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
