parthchandra commented on code in PR #1667:
URL: https://github.com/apache/datafusion-comet/pull/1667#discussion_r2056942543
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -161,10 +161,28 @@ class CometSparkSessionExtensions
}
if (!schemaSupported) {
- fallbackReasons += s"Unsupported schema ${scanExec.requiredSchema}
for $scanImpl"
+ val field: Option[StructField] =
+ CometNativeScanExec
+ .findUnsupportedField(scanExec.requiredSchema)
+
.orElse(CometScanExec.findUnsupportedField(scanExec.requiredSchema))
+ assert(field.nonEmpty)
+ fallbackReasons +=
+ s"Unsupported field ${field.get} in schema
${scanExec.requiredSchema} for $scanImpl"
Review Comment:
I like the idea of collecting the fallback reasons as part of the
`isTypeSupported` call and yes, renaming it to `validateTypeSupported` would be
a good idea in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
