andygrove commented on code in PR #1667:
URL: https://github.com/apache/datafusion-comet/pull/1667#discussion_r2054660077
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -161,10 +161,28 @@ class CometSparkSessionExtensions
}
if (!schemaSupported) {
- fallbackReasons += s"Unsupported schema ${scanExec.requiredSchema}
for $scanImpl"
+ val field: Option[StructField] =
+ CometNativeScanExec
+ .findUnsupportedField(scanExec.requiredSchema)
+
.orElse(CometScanExec.findUnsupportedField(scanExec.requiredSchema))
+ assert(field.nonEmpty)
+ fallbackReasons +=
+ s"Unsupported field ${field.get} in schema
${scanExec.requiredSchema} for $scanImpl"
Review Comment:
@comphead @parthchandra @mbutrovich any thoughts on the approach we should
take here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
