Dandandan commented on PR #15770: URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2975351398
> > I think two different phases sounds good. > > I don't really like complicating FilterPushdown with post / pre "phases". Why not creating the `PushDownDynamicFilters` one you suggested earlier? > > My reasoning for using an enum parameter was that there's a lot of shared implementation both on the optimizer side and ExectionPlan side. E.g. the transparent nodes like CoalesceBatchesExec don't really care which phase it is, but FilterExec needs to ignore the dynamic phase and SortExec needs to ignore the static filter pushdown phase. Sounds reasonable. Perhaps just keep it this way and see if we somehow can separate it to 2 different passes later. It seems like the branch https://github.com/pydantic/datafusion/pull/30 passes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
