adriangb commented on code in PR #15770:
URL: https://github.com/apache/datafusion/pull/15770#discussion_r2150957763
##########
datafusion/physical-optimizer/src/filter_pushdown.rs:
##########
@@ -362,17 +363,25 @@ use itertools::izip;
/// [`ProjectionExec`]: datafusion_physical_plan::projection::ProjectionExec
/// [`AggregateExec`]: datafusion_physical_plan::aggregates::AggregateExec
#[derive(Debug)]
-pub struct FilterPushdown {}
+pub struct FilterPushdown {
+ phase: FilterPushdownPhase,
+ name: String,
+}
impl FilterPushdown {
- pub fn new() -> Self {
- Self {}
+ fn new(phase: FilterPushdownPhase) -> Self {
+ Self {
+ phase,
+ name: format!("FilterPushdown({phase})"),
Review Comment:
I feel that if we do that we should rename the enum to `Static/Dynamic`. I
think it's confusing to mix `Static/Dynamic` and `Pre/Post`.
I like `Pre/Post` because that's the actual reason we're splitting it into
two phases: one runs before other optimizations, one runs after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
