Dandandan commented on PR #15770: URL: https://github.com/apache/datafusion/pull/15770#issuecomment-2977736578
> > Sounds reasonable. Perhaps just keep it this way and see if we somehow can separate it to 2 different passes later. > > It seems like the branch [pydantic#30](https://github.com/pydantic/datafusion/pull/30) passes? > > Then since you think that's reasonable I'd like to merge it and go with that instead for now even if we're not 100% sold on either direction it will let us keep iterating. > > I'll wait for your approval before merging this PR into main. I think it's great! I added one suggestion to minimize the changes to the explain output and maybe phrase the "pre" and "post" more as "normal" filter pushdown and "dynamic" filter pushdown? I think that might explain a bit more of what might be happening. Maybe @alamb can verify the (increased) performance improvements once more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
