comphead commented on code in PR #16660:
URL: https://github.com/apache/datafusion/pull/16660#discussion_r2273824579
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -1096,10 +1096,37 @@ impl NestedLoopJoinStream {
};
// Only setting up timer, input is exhausted
- let _timer = self.join_metrics.join_time.timer();
+ let timer = self.join_metrics.join_time.timer();
// use the global left bitmap to produce the left indices and
right indices
- let (left_side, right_side) =
- get_final_indices_from_shared_bitmap(visited_left_side,
self.join_type);
+
+ let (left_side, right_side) = get_final_indices_from_shared_bitmap(
+ visited_left_side,
Review Comment:
`visited_left_side` awesome name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
