jonathanc-n commented on code in PR #16660:
URL: https://github.com/apache/datafusion/pull/16660#discussion_r2274737986


##########
datafusion/physical-plan/src/joins/piecewise_merge_join.rs:
##########
@@ -0,0 +1,2071 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use arrow::array::{new_null_array, Array, RecordBatchOptions};
+use arrow::compute::take;
+use arrow::{
+    array::{
+        ArrayRef, BooleanBufferBuilder, RecordBatch, UInt32Array, 
UInt32Builder,
+        UInt64Array, UInt64Builder,
+    },
+    compute::{concat_batches, sort_to_indices, take_record_batch},
+    util::bit_util,
+};
+use arrow_schema::{ArrowError, Schema, SchemaRef, SortOptions};
+use datafusion_common::NullEquality;
+use datafusion_common::{
+    exec_err, internal_err, plan_err, utils::compare_rows, JoinSide, Result, 
ScalarValue,
+};
+use datafusion_execution::{
+    memory_pool::{MemoryConsumer, MemoryReservation},
+    RecordBatchStream, SendableRecordBatchStream,
+};
+use datafusion_expr::{JoinType, Operator};
+use datafusion_functions_aggregate_common::min_max::{max_batch, min_batch};
+use datafusion_physical_expr::equivalence::join_equivalence_properties;
+use datafusion_physical_expr::{
+    LexOrdering, OrderingRequirements, PhysicalExpr, PhysicalExprRef, 
PhysicalSortExpr,
+};
+use datafusion_physical_expr_common::physical_expr::fmt_sql;
+use futures::{Stream, StreamExt, TryStreamExt};
+use parking_lot::Mutex;
+use std::fmt::Formatter;
+use std::{cmp::Ordering, task::ready};
+use std::{sync::Arc, task::Poll};
+
+use crate::execution_plan::{boundedness_from_children, EmissionType};
+
+use crate::joins::sort_merge_join::compare_join_arrays;
+use crate::joins::utils::{
+    get_final_indices_from_shared_bitmap, symmetric_join_output_partitioning,
+};
+use crate::{handle_state, DisplayAs, DisplayFormatType, 
ExecutionPlanProperties};
+use crate::{
+    joins::{
+        utils::{
+            build_join_schema, BuildProbeJoinMetrics, OnceAsync, OnceFut,
+            StatefulStreamResult,
+        },
+        SharedBitmapBuilder,
+    },
+    metrics::ExecutionPlanMetricsSet,
+    spill::get_record_batch_memory_size,
+    ExecutionPlan, PlanProperties,
+};
+
+/// `PiecewiseMergeJoinExec` is a join execution plan that only evaluates 
single range filter.
+///
+/// The physical planner will choose to evalute this join when there is only 
one range predicate. This
+/// is a binary expression which contains [`Operator::Lt`], 
[`Operator::LtEq`], [`Operator::Gt`], and
+/// [`Operator::GtEq`].:
+/// Examples:
+///  - `col0` < `colb`, `col0` <= `colb`, `col0` > `colb`, `col0` >= `colb`
+///
+/// Since the join only support range predicates, equijoins are not supported 
in `PiecewiseMergeJoinExec`,
+/// however you can first evaluate another join and run 
`PiecewiseMergeJoinExec` if left with one range
+/// predicate.
+///
+/// # Execution Plan Inputs
+/// For `PiecewiseMergeJoin` we label all left inputs as the `streamed' side 
and the right outputs as the
+/// 'buffered' side.
+///
+/// `PiecewiseMergeJoin` takes a sorted input for the side to be buffered and 
is able to sort streamed record
+/// batches during processing. Sorted input must specifically be 
ascending/descending based on the operator.
+///
+/// # Algorithms
+/// Classic joins are processed differently compared to existence joins.
+///
+/// ## Classic Joins (Inner, Full, Left, Right)
+/// For classic joins we buffer the right side (buffered), and incrementally 
process the left side (streamed).
+/// Every streamed batch is sorted so we can perform a sort merge algorithm. 
For the buffered side we want to
+/// have it already sorted either ascending or descending based on the 
operator as this allows us to emit all
+/// the rows from a given point to the end as matches. Sorting the streamed 
side allows us to start the pointer
+/// from the previous row's match on the buffered side.
+///
+/// Here is an example:
+///
+/// We perform a `JoinType::Left` with these two batches and the operator 
being `Operator::Lt`(<). For each
+/// row on the streamed side we move a pointer on the buffered until it 
matches the condition. Once we reach
+/// the row which matches (in this case with row 1 on streamed will have its 
first match on row 2 on
+/// buffered; 100 < 200 is true), we can emit all rows after that match. We 
can emit the rows like this because
+/// if the batch is sorted in ascending order, every subsequent row will also 
satisfy the condition as they will
+/// all be larger values.
+///
+/// ```text
+/// SQL statement:
+/// SELECT *
+/// FROM (VALUES (100), (200), (500)) AS streamed(a)
+/// LEFT JOIN (VALUES (100), (200), (200), (300), (400)) AS buffered(b)
+///   ON streamed.a < buffered.b;
+/// 
+/// Processing Row 1:
+///
+///            Sorted Streamed Side          Sorted Buffered Side  
+///            ┌──────────────────┐          ┌──────────────────┐
+///          1 │       100        │        1 │       100        │
+///            ├──────────────────┤          ├──────────────────┤
+///          2 │       200        │        2 │       200        │ ─┐  
+///            ├──────────────────┤          ├──────────────────┤  │  For row 
1 on streamed side with
+///          3 │       500        │        3 │       200        │  │  value 
100, we emit rows 2 - 5
+///            └──────────────────┘          ├──────────────────┤  │  as 
matches when the operator is
+///                                        4 │       300        │  │  
`Operator::Lt` (<) Emitting all
+///                                          ├──────────────────┤  │  rows 
after the first match (row 2
+///                                        5 │       400        │ ─┘  buffered 
side; 100 < 200)
+///                                          └──────────────────┘     
+///
+/// Processing Row 2:
+///   By sorting the streamed side we know
+///
+///            Sorted Streamed Side          Sorted Buffered Side  
+///            ┌──────────────────┐          ┌──────────────────┐
+///          1 │       100        │        1 │       100        │
+///            ├──────────────────┤          ├──────────────────┤
+///          2 │       200        │        2 │       200        │ <- Start 
here when probing for the streamed
+///            ├──────────────────┤          ├──────────────────┤    side row 
2.
+///          3 │       500        │        3 │       200        │
+///            └──────────────────┘          ├──────────────────┤
+///                                        4 │       300        │
+///                                          ├──────────────────┤
+///                                        5 │       400        |
+///                                          └──────────────────┘
+/// ```
+///
+/// ## Existence Joins (Semi, Anti, Mark)
+/// Existence joins are made magnitudes of times faster with a 
`PiecewiseMergeJoin` as we only need to find
+/// the min/max value of the streamed side to be able to emit all matches on 
the buffered side. By putting
+/// the side we need to mark onto the sorted buffer side, we can emit all 
these matches at once.
+///
+/// For Left Semi, Anti, and Mark joins we swap the inputs so that the marked 
side is on the buffered side.

Review Comment:
   Yes the logic can be found in `execute()`
   
   ```
   // If the join type is either LeftSemi, LeftAnti, or LeftMark we will swap 
the inputs
           // and sort ordering because we want the mark side to be the 
buffered side.
           let (streamed, buffered, on_streamed, on_buffered, operator) =
               if is_left_existence_join(self.join_type) {
                   (
                       Arc::clone(&self.buffered),
                       Arc::clone(&self.streamed),
                       on_buffered,
                       on_streamed,
                       self.operator.swap().unwrap(),
                   )
               } else {
                   (
                       Arc::clone(&self.streamed),
                       Arc::clone(&self.buffered),
                       on_streamed,
                       on_buffered,
                       self.operator,
                   )
               };
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to