mbutrovich commented on code in PR #17195:
URL: https://github.com/apache/datafusion/pull/17195#discussion_r2277377451
##########
datafusion/functions/src/regex/regexpreplace.rs:
##########
@@ -398,12 +394,37 @@ fn _regexp_replace_early_abort<T: ArrayAccessor>(
/// Note: If the array is empty or the first argument is null,
/// then calls the given early abort function.
macro_rules! fetch_string_arg {
- ($ARG:expr, $NAME:expr, $T:ident, $EARLY_ABORT:ident, $ARRAY_SIZE:expr) =>
{{
- let array = as_generic_string_array::<$T>($ARG)?;
- if array.len() == 0 || array.is_null(0) {
- return $EARLY_ABORT(array, $ARRAY_SIZE);
- } else {
- array.value(0)
+ ($ARG:expr, $NAME:expr, $EARLY_ABORT:ident, $ARRAY_SIZE:expr) => {{
Review Comment:
I'm not sure how the `T` argument worked before, since it's based on whether
`arg[0]` was `Utf8` or `LargeUtf8` and shouldn't affect the other argument
arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
