mbutrovich commented on code in PR #17195:
URL: https://github.com/apache/datafusion/pull/17195#discussion_r2279783095
##########
datafusion/functions/src/regex/regexpreplace.rs:
##########
@@ -238,15 +258,17 @@ fn regex_replace_posix_groups(replacement: &str) ->
String {
/// # Ok(())
/// # }
/// ```
-pub fn regexp_replace<'a, T: OffsetSizeTrait, V, B>(
- string_array: V,
- pattern_array: B,
- replacement_array: B,
- flags: Option<&ArrayRef>,
+pub fn regexp_replace_with_flags<'a, T: OffsetSizeTrait, U, V, W, X>(
+ string_array: U,
+ pattern_array: V,
Review Comment:
All 4 arrays can now be different types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
