mbutrovich commented on code in PR #17195:
URL: https://github.com/apache/datafusion/pull/17195#discussion_r2277379010
##########
datafusion/functions/src/regex/regexpreplace.rs:
##########
@@ -650,8 +665,8 @@ mod tests {
vec!["afooc", "acd", "afoocd1234567890123",
"123456789012afooc"];
let values = <$T>::from(values);
- let patterns = StringArray::from(patterns);
- let replacements = StringArray::from(replacement);
+ let patterns = <$U>::from(patterns);
+ let replacements = <$U>::from(replacement);
Review Comment:
I change all of the other arg string types at once since they hit the same
code path (`fetch_string_arg`) so I don't think we need to test them
independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
