mbutrovich opened a new pull request, #17195:
URL: https://github.com/apache/datafusion/pull/17195
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
#11667 added some `Uft8View` support for `regexp_replace`, but only for the
first argument. The other args only support `Uft8`, which likely isn't a huge
deal since they're probably short literals, but adding support for other string
types makes it easier to simplify the signature. Systems like Comet (which may
emit string literals as `Utf8View`) will also benefit from being able to use
this function.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Change the signature to rely on the logical string type. Oddly enough,
though there was logic for `LargeUtf8` the signature did not list it, so not
sure this worked end-to-end for `LargeUtf8`.
- Modify `fetch_string_arg` to support other string types besides `Utf8`.
- Remove logic in `return_type` that mentioned binary types. This function
does not support binary types.
- Add unit tests for other string types.
- Add end-to-end tests for other string types.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, there are new tests. See above.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
The signature for `regexp_replace` changed, but it was wrong before (did not
have `LargeUtf8`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
