coderfender commented on code in PR #2136:
URL: https://github.com/apache/datafusion-comet/pull/2136#discussion_r2288881170
##########
native/spark-expr/src/math_funcs/checked_arithmetic.rs:
##########
@@ -27,19 +30,33 @@ pub fn try_arithmetic_kernel<T>(
left: &PrimitiveArray<T>,
right: &PrimitiveArray<T>,
op: &str,
+ is_ansi_mode: bool,
) -> Result<ArrayRef, DataFusionError>
where
T: ArrowPrimitiveType,
{
let len = left.len();
let mut builder = PrimitiveBuilder::<T>::with_capacity(len);
+ let error_msg = format!("{} : [ARITHMETIC_OVERFLOW] integer overflow. Use
'try_{}' to tolerate overflow and return NULL instead", op,
op.split("_").last().unwrap());
Review Comment:
Thank you @parthchandra , I removed the custom message and leveraged Spark
standard exceptions to ensure consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
