parthchandra commented on PR #2136: URL: https://github.com/apache/datafusion-comet/pull/2136#issuecomment-3216035635
> here is a test failure in Spark 4.0 where division operation is failing (as expected in ANSI mode) but the error message `cannot divide by zero` is what spark tests are expecting but now that the division op is sent to comet, the error message is different. We have two options to go forward > > 1. Change the error message to match exactly with Spark > 2. Update test in spark , create a new diff file pass the test. > > I am inclined towards #1 given the effort to reward ratio @mbutrovich I seem to recall that you had a solution for this kind of test failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
