hsiang-c commented on code in PR #2595:
URL: https://github.com/apache/datafusion-comet/pull/2595#discussion_r2441174434
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -504,10 +504,10 @@ abstract class CometTestBase
| optional float _6;
| optional double _7;
| optional binary _8(UTF8);
- | optional int32 _9(UINT_8);
- | optional int32 _10(UINT_16);
- | optional int32 _11(UINT_32);
- | optional int64 _12(UINT_64);
+ | optional int32 _9(INT_8);
Review Comment:
We store negative values in these columns, I think the schema should not be
unsigned int.
```scala
// CometTestBase.scala
record.add(8, (-i).toByte)
record.add(9, (-i).toShort)
record.add(10, -i)
record.add(11, (-i).toLong)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
