parthchandra commented on code in PR #2595:
URL: https://github.com/apache/datafusion-comet/pull/2595#discussion_r2441396435
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -504,10 +504,10 @@ abstract class CometTestBase
| optional float _6;
| optional double _7;
| optional binary _8(UTF8);
- | optional int32 _9(UINT_8);
- | optional int32 _10(UINT_16);
- | optional int32 _11(UINT_32);
- | optional int64 _12(UINT_64);
+ | optional int32 _9(INT_8);
Review Comment:
We have UINT here to make sure we cover all types that parquet has. The data
files created here are specifically designed to test whether parquet readers
can handle all types correctly. Negative values stored in a UINT parquet type
test the values around the boundary of allowed values.
To illustrate with an example, when you store the value -1 in a UINT_8 field
what gets stored is the bit pattern 0xff. On reading, this is read back as the
value 255 which is the maximum value for a UINT_8.
This is both correct and desirable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
