iffyio commented on issue #2076: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2076#issuecomment-3461428251
@LucaCappelletti94 would the intent be to remove whitespace characters specifically or all of the parser's representations of whitespace? For the former I'm not super sure in general if the parser (or downstream users of the tokenizer) can always disambiguate some of rarer cases going forward without relying on detecting whitespace - I think the current usages of the `*no_skip` methods could give us an idea. For the latter, it seems that are some cases like [this PR](https://github.com/apache/datafusion-sqlparser-rs/pull/2034) that will require keeping around any comments (which the parser also represents as whitespace). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
