alamb commented on issue #2076: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2076#issuecomment-3487630491
> The overall goal sounds reasonable to me, but I'm not sure that I can fully judge the impact of the changes > > [@alamb](https://github.com/alamb) [@yoavcloud](https://github.com/yoavcloud) do you have any thoughts on whether discarding whitespace and essentially removing `Token::Whitespace` would be desirable? It seems reasonable to me -- one way to judge the impact of such a change would be to try it out with some other downstream project (e.g. DataFusion). I did a quick search and didn't see any such issues https://github.com/search?q=repo%3Aapache%2Fdatafusion+Token%3A%3AWhitespace&type=code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
