LucaCappelletti94 commented on issue #2076: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2076#issuecomment-3461469838
The #2077 PR basically moves all of the whitespace related processing in the tokenizer, so that the parser can then entirely be freed of dealing with them. There are some corner cases (the ones listed above) but I feel I ended up dealing with them in a reasonably clean manner. Having removed whitespaces entirely in PR #2077, I can say that the resulting code seems to be much cleaner, and the `*_no_skip` methods have been entirely removed. I don't see how the #2034 PR would be blocked by this merge - it is simply another type of comment. PR #2069 (from a PhD student in my team) in its current version will be comparatively more affected, but after this change it should be exceedingly easier to add support for such leading comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
