LucaCappelletti94 commented on issue #2076: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2076#issuecomment-3489762140
> It seems reasonable to me -- one way to judge the impact of such a change would be to try it out with some other downstream project (e.g. DataFusion). I did a quick search and didn't see any such issues There’s already a branch with PR #2077 if you’d like to test whether it breaks anything downstream. In that branch, I removed several (previously pub) methods related to advancing the parser while skipping or not skipping spaces, and removed the Whitespace token entirely, which I believe is the right approach, as retaining it seems to encourage anti-patterns in SQL parsing (given how often whitespace-specific checks appeared). While it’s technically possible that someone has extended the tokenizer or parser to rely on whitespace, I’d argue that doing so would already be an anti-pattern and not something we should encourage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
