Standing-Man commented on code in PR #18768:
URL: https://github.com/apache/datafusion/pull/18768#discussion_r2540975640
##########
datafusion/functions/src/core/greatest_least_utils.rs:
##########
@@ -102,8 +102,8 @@ pub(super) fn execute_conditional<Op:
GreatestLeastOperator>(
// Start with the result value
result = keep_array::<Op>(
- Arc::clone(first_array),
- result_scalar.to_array_of_size(first_array.len())?,
+ &Arc::clone(first_array),
Review Comment:
Thank you for the suggestion. I’ve reduced unnecessary cloning in the new
commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
