Jefffrey commented on code in PR #18768:
URL: https://github.com/apache/datafusion/pull/18768#discussion_r2548326233
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -295,7 +295,7 @@ impl DigestAlgorithm {
pub fn digest_utf8_array_impl<'a, StringArrType>(
self,
- input_value: StringArrType,
+ input_value: &StringArrType,
Review Comment:
My point is this might be a false positive by clippy because if we look here
for example:
https://github.com/apache/datafusion/blob/f1ecaccd183367086ecb5b7736d93b3aba109e01/datafusion/functions/src/crypto/basic.rs#L260-L263
`v` is already of type `&GenericBinaryArray<T>`; it is already a reference 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
