Jefffrey commented on code in PR #18768:
URL: https://github.com/apache/datafusion/pull/18768#discussion_r2544125824
##########
datafusion/functions/src/crypto/basic.rs:
##########
@@ -295,7 +295,7 @@ impl DigestAlgorithm {
pub fn digest_utf8_array_impl<'a, StringArrType>(
self,
- input_value: StringArrType,
+ input_value: &StringArrType,
Review Comment:
But if we look at `StringArrayType` it is implemented for references:
https://docs.rs/arrow/latest/arrow/array/trait.StringArrayType.html
##########
datafusion/functions/src/core/greatest_least_utils.rs:
##########
@@ -38,8 +38,8 @@ pub(super) trait GreatestLeastOperator {
}
fn keep_array<Op: GreatestLeastOperator>(
- lhs: ArrayRef,
- rhs: ArrayRef,
+ lhs: &ArrayRef,
+ rhs: &ArrayRef,
Review Comment:
`&ArrayRef` can also be simplified to `&dyn Array` I believe?
##########
datafusion/functions/src/core/getfield.rs:
##########
@@ -246,10 +246,10 @@ impl ScalarUDFImpl for GetFieldFunc {
}
fn process_map_with_nested_key(
- array: Arc<dyn Array>,
- key_array: Arc<dyn Array>,
+ array: &dyn Array,
+ key_array: &Arc<dyn Array>,
Review Comment:
Key can also be made dyn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
