adriangb commented on PR #18739: URL: https://github.com/apache/datafusion/pull/18739#issuecomment-3622218616
I opened a PR to make `Extensions` private, I think that addresses 1/2 of the concern: https://github.com/apache/datafusion/pull/19180 My view on the other change is that it's a pretty straightforward change, and doesn't force *any code to be changed by users of DataFusion*. All old code continues to work until and only if we decide to deprecate the old method. We also added the change into the upgrade guide. I think all of that combined with the wide availability of AI tools means that this sort of API change is easy to absorb compared to DataFusion 7 -> 8. @gabotechs what do you think of @milenkovicm's proposed solution? If I understand correctly the idea is that the optimizer takes a reference to the `SessionConfig` via it's constructor. I think this would make things more verbose for these sorts of optimizers, and it doesn't let us unify the API with the logical optimizer (which *does have an `OptimizerContext`*), which was one of the goals of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
