gabotechs commented on PR #18739: URL: https://github.com/apache/datafusion/pull/18739#issuecomment-3622766877
> There is nothing you mentioned in https://github.com/apache/datafusion/pull/18168 that can't be done with the previous API This is true, for what is worth, we can leave the `PhysicalOptimizerRule::optimize` with empty arguments and we'd still be able to prompt users to pass everything in the constructors. I'm fine in rolling back this change and finish the discussion here, are you fine with that @adriangb? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
