gabotechs commented on PR #18739: URL: https://github.com/apache/datafusion/pull/18739#issuecomment-3622463407
> I would leave up to you to make such decision, you're the one approving the PR; I personally struggle to see value of this PR at this moment. If it was only up to me, I'd say the change in this PR is appropriate and I'm good with going forward with it. It's not only up to me though, we should also weight opinions of other contributors like you, and specially yours as long tenured contributed to DataFusion. Would you be fine with a more contained change that uses `SessionConfig` instead of `ConfigOptions` as `PhysicalOptimizerRule::optimize` argument? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
