Brijesh-Thakkar commented on code in PR #19587:
URL: https://github.com/apache/datafusion/pull/19587#discussion_r2656226644
##########
datafusion/common/src/scalar/mod.rs:
##########
@@ -5760,10 +5764,9 @@ mod tests {
.unwrap(),
Ordering::Less
);
- assert_eq!(
+ assert!(
ScalarValue::try_cmp(&ScalarValue::Int32(None),
&ScalarValue::Int32(Some(2)))
Review Comment:
I’ve updated the doc comment for try_cmp to explicitly document that it now
also returns an error when either input is NULL, and clarified the distinction
with partial_cmp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
