Brijesh-Thakkar commented on code in PR #19587:
URL: https://github.com/apache/datafusion/pull/19587#discussion_r2656228679
##########
datafusion/common/src/utils/mod.rs:
##########
@@ -1026,22 +1026,26 @@ mod tests {
ScalarValue::Int32(Some(2)),
Null,
ScalarValue::Int32(Some(0)),
- ] < vec![
+ ]
+ .partial_cmp(&vec![
ScalarValue::Int32(Some(2)),
Null,
ScalarValue::Int32(Some(1)),
- ]
+ ])
+ .is_none()
Review Comment:
Thanks for the detailed explanation and references
I agree that for composite types (arrays / vectors), following PostgreSQL
and DuckDB’s lexicographical ordering makes sense, even when NULLs are present.
I’ll update the test to expect a deterministic ordering (true in this case)
instead of propagating NULL, aligning with PostgreSQL behavior and DataFusion’s
pruning logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
