2010YOUY01 commented on PR #19587: URL: https://github.com/apache/datafusion/pull/19587#issuecomment-3705161679
> @2010YOUY01 I’ve verified locally that the change behaves correctly and passes within scope: > > cargo test -p datafusion-common > > cargo clippy -p datafusion-common -- -D warnings > > The remaining CI failures appear to be workspace-level (benchmarks / allocator / FFI) and unrelated to the ScalarValue::partial_cmp NULL semantics change. I think they're failing because this PR's change has propagated to other places, we have to make sure all of them are passing. This failure looks like a behavior change propagation https://github.com/apache/datafusion/actions/runs/20653578399/job/59303606434?pr=19587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
