Brijesh-Thakkar commented on PR #19587: URL: https://github.com/apache/datafusion/pull/19587#issuecomment-3706060955
I’ve pushed follow-up fixes to address all downstream failures caused by the updated ScalarValue::partial_cmp NULL semantics: Updated ORDER BY rewrite logic to correctly handle aggregate aliases and preserve casts Fixed logical plan comparison and ordering assumptions impacted by NULL → None comparisons Resolved all related clippy warnings under -D warnings I’ve verified locally that the following now pass: cargo fmt --all cargo clippy --all-targets --all-features -- -D warnings cargo test -p datafusion-expr --lib cargo test -p datafusion-common The changes are now consistent across scalar comparison, vector ordering, and logical plan rewrites, with no remaining behavior mismatches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
