milenkovicm commented on PR #20037: URL: https://github.com/apache/datafusion/pull/20037#issuecomment-3811010882
I believe converter should not be shared between thread as well, my guess that it's `Send` and `Sync` at the moment. As converter is pluggable, my suggestion would be to implement caching implementation in `datafusion-distributed` give it a run for few months, battle test it and the we could re-open this conversation again or we could implement it here, as a `CachingConverter` but keep `DefaultConverter` as default and noop (as it was) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
