adriangb commented on PR #20037: URL: https://github.com/apache/datafusion/pull/20037#issuecomment-3811449048
I don’t see how this isn’t a bug. You roundtrip a plan through protobuf and it becomes 1000x slower or uses 1000x more memory. Does that not impact users? In my mind the reason to make the change was so that we could implement this sort of thing in the first place, not so it could live somewhere else. The pluggable aspect was to support serialization of unknown dynamic hooks like SchemaAdapter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
