milenkovicm commented on PR #20037: URL: https://github.com/apache/datafusion/pull/20037#issuecomment-3811528179
As far as I remember outcome of our discussion was to make this interface pluggable, and if it the cache is needed users can implement. That was on the community call few months back. I believe that with Tim's PR this discussion was closed. I was very surprised that you have open this discussion again. Converter is not consumed, it can be reused, that is the core problem. It can also be reused across multiple threads, "reset depth" is broken from that perspective as well. From the perspective of user impacts, I see no complain. I do not remember seeing plan ser/de in any heat map as a problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
